Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for systemd socket activation #223

Merged
merged 6 commits into from
Jan 24, 2023

Conversation

iavael
Copy link
Contributor

@iavael iavael commented Jan 17, 2023

Summary

In this PR there are systemd user units for gitsign-credential-cache for a better integration on linux systemd with systemd. Also gitsign-credential-cache was modified for socket activation support.

Release Note

Added parameter -s to gitsign-credential-cache for socket activation support

Documentation

README was adjusted

Closes #222

Signed-off-by: Iavael <905853+iavael@users.noreply.github.com>
@iavael iavael force-pushed the feature/socket-activation branch 2 times, most recently from 8552d71 to cb57b6d Compare January 17, 2023 13:39
Signed-off-by: Iavael <905853+iavael@users.noreply.github.com>
Signed-off-by: Iavael <905853+iavael@users.noreply.github.com>
Signed-off-by: Iavael <905853+iavael@users.noreply.github.com>
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! 🙏

Some comments, primarily to be defensive if this flag is invoked on a non-systemd machine.

cmd/gitsign-credential-cache/main.go Outdated Show resolved Hide resolved
cmd/gitsign-credential-cache/main.go Show resolved Hide resolved
cmd/gitsign-credential-cache/main.go Show resolved Hide resolved
cmd/gitsign-credential-cache/main.go Show resolved Hide resolved
@wlynch
Copy link
Member

wlynch commented Jan 18, 2023

cc @eddiezane in case you have any other comments

Signed-off-by: Iavael <905853+iavael@users.noreply.github.com>
…o cache daemon

Signed-off-by: Iavael <905853+iavael@users.noreply.github.com>
cmd/gitsign-credential-cache/main.go Show resolved Hide resolved
cmd/gitsign-credential-cache/main.go Outdated Show resolved Hide resolved
@wlynch wlynch merged commit ac61585 into sigstore:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Systemd support for gitsign-credential-cache
3 participants